Use new py::make_scalar and dtype.normalized_num#3816
Merged
Conversation
SimonHeybrock
approved these changes
Jan 21, 2026
jl-wynen
force-pushed
the
new-pybind11-3-features
branch
from
a046a4f to
288b9f8
Compare
jl-wynen
force-pushed
the
new-pybind11-3-features
branch
2 times, most recently
from
4b08dc0 to
bf5214a
Compare
SimonHeybrock
approved these changes
Jan 22, 2026
jl-wynen
force-pushed
the
new-pybind11-3-features
branch
from
bf5214a to
bbb8c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the new features in Pybind11 and found two that are useful to us. Please look at the commits separately! Consider this PR more of a proposal, not a request. This only improves readability in code we never actually look at.
py::make_scalaralmost implements what we did ourselves inmake_scalarbut only supports numeric types (for now). There is a breaking change here:sc.scalar(False).valueis currently abool. With this change, this turns into anp.bool_. I think this makes sense for consistency with NumPy. It should not break anything in practice unless someone uses code likevar.value is True, which is bad code anyway.normalized_numandnum_ofmake it more straight forward to check dtypes. But they don't support all types we need as far as I can tell. So the proposedscipp_dtypeis simpler than before (no nesting) but not as clean as I had hoped.