Drop conan, use cpm for cpp deps during building wheels#3814
Drop conan, use cpm for cpp deps during building wheels#3814MridulS merged 3 commits intoscipp:mainfrom
Conversation
MridulS
changed the title
|
This is ready for review. All wheel were built and tested https://github.com/scipp/scipp/actions/runs/21188766372 |
jl-wynen
left a comment
jl-wynen
left a comment
There was a problem hiding this comment.
From what I can tell, this looks good. And judging by the comments, this must have been very frustrating to set up correctly. So well done!
| GIT_TAG | ||
| v1.15.0 | ||
| VERSION | ||
| 1.15.0 |
There was a problem hiding this comment.
Is there an easy way to use the versions from the buildconfig files? We risk them diverging by specifying versions here and in the buildconfig. (This is not new, I am just wondering if we now have a better alternative.)
There was a problem hiding this comment.
Yeah I'm not really sure and they have been diverging for some time I think?
Like here boost 1.90 is available direct from source but the latest boost on conda-forge is 1.88
There was a problem hiding this comment.
I asked claude and one of the suggestions is:
Single YAML/JSON source file - Create a versions.yml or versions.json that both CMake (via file(READ)
- parsing) and conda configs reference. CMake can parse simple formats.
But this also means creating a python script that reads the file and creates the build config envs.
There was a problem hiding this comment.
But this also means creating a python script that reads the file and creates the build config envs.
That wouldn't be great. Then you would need python to install python.
| set(BOOST_INCLUDE_LIBRARIES container iterator) | ||
| cpmaddpackage( | ||
| NAME | ||
| Boost | ||
| VERSION | ||
| 1.90.0 |
There was a problem hiding this comment.
Here the version 1.90 is required, and indeed since it is required for the boost component boost::container. However the file lib/CMakeLists.txt requires a boost of version 1.67 or above. lib/CMakeLists.txt should have been updated to require boost 1.90 or above.
3 participants
No description provided.