fix: require lookup coordinate is floating when mode is nearest#3779
Merged
fix: require lookup coordinate is floating when mode is nearest#3779
Conversation
SimonHeybrock
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/scipp/esspolarization/actions/runs/18703900087/job/53338032043#step:6:161 in the sense that it requires the lookup coordinate to be float, so it will raise a clearer error message.
The lookup table code is not tested with coords having integer dtype, I'm not sure that results are even correct in that case, so I opted for just adding the exception here for now.
Maybe we should consider adding support for integer lookup coordinates in the future.