Merged
Conversation
jl-wynen
reviewed
Aug 4, 2025
| - cmake=4.0.0 | ||
| - conan=1.66.0 | ||
| - cppcheck=2.6.2 | ||
| - cppcheck=2.18.0 |
Member
There was a problem hiding this comment.
Was this necessary for updating to py 3.11?
Member
Author
There was a problem hiding this comment.
yes, the min cppcheck that is built on conda-forge with py3.11 is 2.18.0 :/
MridulS
commented
Aug 4, 2025
Comment on lines
+39
to
+52
| uninitMemberVar | ||
| passedByValue | ||
| duplInheritedMember | ||
| throwInNoexceptFunction | ||
| returnByReference | ||
| constParameterReference | ||
| constStatement | ||
| normalCheckLevelMaxBranches | ||
| constVariableReference | ||
| missingReturn | ||
| passedByValueCallback | ||
| unreadVariable | ||
| accessMoved | ||
| unusedStructMember |
Member
Author
There was a problem hiding this comment.
I don't know enough to comment if this is an actual issue or not.
Member
There was a problem hiding this comment.
Can you open an issue so we don't forget looking into this?
Member
Author
There was a problem hiding this comment.
Created #3740 to keep a track, maybe we can merge this in for now to move with dropping python 3.10?
jl-wynen
approved these changes
Aug 4, 2025
SimonHeybrock
added a commit
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mantid supports python 3.11 now https://github.com/mantidproject/mantid/releases