Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

[MRG] Improve sampler #851

Merged
holgern merged 9 commits into from
Feb 20, 2020
Merged

[MRG] Improve sampler #851

holgern merged 9 commits into from
Feb 20, 2020

Conversation

@holgern
Copy link
Contributor

@holgern holgern commented Feb 19, 2020 •
edited
Loading

  • Add cook_initial_point_generator and grid
  • Rename n_random_starts to n_random_starts
  • n_random_starts is deprecated
  • init_point_gen_kwargs is removed from optimizer init
  • InitialPointGenerator has set_params

holgern and others added 5 commits February 19, 2020 18:45
@holgern
Merge pull request #46 from scikit-optimize/master
aea940f 
merge upstream
@holgern
Merge pull request #48 from scikit-optimize/master
d4aabbc 
Merge upstream
@holgern
Rename test and increase min numpy version to 1.12
4308659
@holgern
Add cook_initial_point_generator and grid
3c956a6 
* Rename n_random_starts to n_random_starts
* n_random_starts is deprecated
* init_point_gen_kwargs is removed from optimizer init
* InitialPointGenerator has set_params
@holgern
Fix unit test
d90109c
@pep8speaks
Copy link

pep8speaks commented Feb 20, 2020 •
edited
Loading

Hello @holgern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 34:1: E402 module level import not at top of file

Line 35:1: E402 module level import not at top of file

Line 134:1: E402 module level import not at top of file

Comment last updated at 2020-02-20 16:29:35 UTC

@holgern holgern changed the title [WIP] Improve sampler [MRG] Improve sampler Feb 20, 2020
@holgern holgern merged commit 4d6d749 into scikit-optimize:master Feb 20, 2020
@holgern holgern deleted the improve_sampler branch February 20, 2020 17:17
@holgern holgern mentioned this pull request Feb 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@holgern @pep8speaks