Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

[MRG] Eval pr #579 - Rewrote parts of plotting functions and add two new plotting functions #848

Merged
holgern merged 30 commits into from
Feb 28, 2020
Merged

[MRG] Eval pr #579 - Rewrote parts of plotting functions and add two new plotting functions #848

holgern merged 30 commits into from
Feb 28, 2020

Conversation

@holgern
Copy link
Contributor

@holgern holgern commented Feb 13, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Feb 13, 2020 •
edited
Loading

Hello @holgern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file
Line 20:1: E402 module level import not at top of file
Line 22:1: E402 module level import not at top of file
Line 25:80: E501 line too long (88 > 79 characters)
Line 37:1: E302 expected 2 blank lines, found 1
Line 41:16: E127 continuation line over-indented for visual indent
Line 51:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated at 2020-02-28 10:11:15 UTC

holgern added 15 commits February 13, 2020 13:03
@holgern
Remove name, index and _dimension_names
14cf9af
@holgern
Fix typo
4d93aa0
@holgern
Add removed regret_plot
f99e5ad
@holgern
Fix doc strings
00548b9
@holgern
Fix order and restore plot functions
0cab51d
@holgern
Add categories back to plot_evaluations
96f9b17
@holgern
Put back in plot_objective for better evaluation
7cd316b
@holgern
Put back in current code for better merging
dba85f6
@holgern
Start to integrate changes
4e772a3 
* partial_dependence_1D and partial_dependence_2D is not used in partial_dependence
* new plot functions are renamed to _new
@holgern
Several improvements in space and plots
65afce6 
* get_samples_dimension is removed
* __getitem__ for space improve, it returns now also the index
* plot_objective_2D fixed
* plot_historgram fixed
@holgern
plot_objective and plot_evaluation have been merged
9b0ce89
@holgern
Cleanup not used functions and pep8 fixes
4c8ffb2
@holgern
pep8 fixes
157a8a5
@holgern
Try to solve conflict
cfca730
@holgern
Fix unit tests
aa3ef13
@holgern holgern changed the title [WIP] Eval pr #579 [WIP] Eval pr #579 - Rewrote parts of plotting functions and add two new plotting functions Feb 27, 2020
@holgern holgern changed the title [WIP] Eval pr #579 - Rewrote parts of plotting functions and add two new plotting functions [MRG] Eval pr #579 - Rewrote parts of plotting functions and add two new plotting functions Feb 28, 2020
@holgern holgern merged commit 025c26d into scikit-optimize:master Feb 28, 2020
@holgern holgern deleted the eval_PR_579 branch February 28, 2020 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holgern @pep8speaks @Hvass-Labs