Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Conversation

@jnothman
Copy link

@jnothman jnothman commented Aug 6, 2017

It was a dare.

@betatim
Copy link
Member

betatim commented Aug 7, 2017

Should we review this?

Maybe we should add some comments to the line of code because to me it is not clear why it causes so many test failures :-/

@betatim
Copy link
Member

betatim commented Aug 7, 2017

I think the dare resulted from #462 (comment) (I am a bit slow today :)

@glouppe
Copy link
Member

glouppe commented Aug 7, 2017

@jnothman
Copy link
Author

jnothman commented Aug 8, 2017

Right, thanks. I'd not checked the tests.

@jnothman
Copy link
Author

jnothman commented Aug 8, 2017

You mean you want it to store zeros if not normalize_y?

@jnothman
Copy link
Author

jnothman commented Aug 8, 2017

This change isn't passing tests locally. I might leave it to you folks to fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants