This repository was archived by the owner on Feb 28, 2024. It is now read-only.
[MRG] ci: Add GitHub Actions workflow based CI #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @matthewfeickert! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-04 07:41:35 UTC |
Author
|
@scikit-optimize, @betatim, @glouppe, @holgern This PR is ready for review and is passing (the CI it adds) on my fork:
Let me know if you have any questions. 👍 Note that GitHub Actions does support PyPy, but that's probably worth its own workflow. |
matthewfeickert
commented
Oct 4, 2021
Comment on lines
+54
to
+58
| - name: Setup testing environment | ||
| run: | | ||
| mkdir tmp | ||
| cp setup.cfg tmp/ | ||
| pushd tmp |
Author
There was a problem hiding this comment.
Note this can all be avoided if a src directory structure is used, but that's a whole separate Issue discussion and possible future PR.
scikit-learn v1.0 has incompatible API changes from v0.X
Run pytest tests on Ubuntu across CPython 3.6, 3.7, 3.8, 3.9 and on macOS for CPython v3.9. Run on: * push events to master and tags * pull request events to master * daily CRON job scheduled for 1:23 UTC * on demand with workflow dispatch
matthewfeickert
force-pushed
the
ci/add-GHA-based-ci
branch
from
c3eadab to
7855c5c
Compare
Author
|
(Force pushed to resolve the flake8 complaint due to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to address Issue #1060 by adding in just the testing component in a GitHub Actions based workflow. All other workflows (linting, docs, deployment) will be added in follow up PRs in an effort to make this PR as atomic as possible. Travis CI support will be removed once all aspects of the CI/CD have been migrated to GHA.
The workflow runs the pytest tests on Ubuntu across CPython 3.6, 3.7, 3.8, 3.9 and on macOS for CPython v3.9. The workflow is activated on:
To get the CI to pass an upper limit on compatible releases of scikit-learn of less than
v1.0(congrats to the scikit-learn team on finally reachingv1.0! 🎉) given incompatible API changes in thev1.0release compared to thev0.XAPI.As this PR adds testing up through CPython v3.9 it adds Python 3.9 to the supported versions in the PyPI metadata in
setup.pyand then adds a status badge for the CI to the README, which will look like