This repository was archived by the owner on Feb 28, 2024. It is now read-only.
Fix numpy Deprecation errors #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
reviewed
Apr 20, 2021
skopt/space/space.py
Outdated
| Name associated with the dimension, e.g., "learning rate". | ||
| dtype : str or dtype, default=np.float | ||
| dtype : str or dtype, default=np.float64 |
Contributor
There was a problem hiding this comment.
Why not just float, since that's what the user will become accustomed to seeing?
skopt/space/space.py
Outdated
| elif isinstance(self.dtype, type) and self.dtype\ | ||
| not in [float, np.float, np.float16, np.float32, np.float64]: | ||
| raise ValueError("dtype must be float, np.float" | ||
| not in [float, np.float16, np.float32, np.float64]: |
Contributor
There was a problem hiding this comment.
I'd promote the condition to:
np.issubdtype(self.dtype, np.floating)or something equivalent.
|
Hello @xmatthias! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-21 14:29:31 UTC |
xmatthias
force-pushed
the
fix_numpy_errors
branch
from
6f9f84b to
1bcd619
Compare
xmatthias
force-pushed
the
fix_numpy_errors
branch
from
1bcd619 to
277aac5
Compare
kernc
reviewed
Apr 21, 2021
skopt/space/space.py
Outdated
| raise ValueError("dtype must be float, np.float" | ||
| elif isinstance(self.dtype, type) and \ | ||
| np.issubdtype(type(self.dtype), np.floating): | ||
| raise ValueError("dtype must be float, np.float64" |
Contributor
There was a problem hiding this comment.
To match the previous check, the condition should probably be negated, though. 😄
Can you also amend the error string?
Contributor
Author
There was a problem hiding this comment.
yeah sure, sorry for the long back and forth!
kernc
reviewed
Apr 21, 2021
kernc
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix some numpy depreciation errors that appear due to the usage of float.
It's also fixing
skopt/learning/gaussian_process/kernels.py:319: DeprecationWarning: invalid escape sequence \s- although i'm not 100% certain how this fix will come out at the docs.Unfortunately, i'm uncertain how to build / verify this - as it doesn't seem to be documented.
I'm hoping that CI passes, as i found no way to get
skopt/tests/test_gp_opt.pyto pass all tests (not with master, not with the modifications ...).