Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Conversation

@gcp
Copy link
Contributor

@gcp gcp commented Apr 3, 2021

Fixes #1017.

@kernc
Copy link
Contributor

kernc commented Apr 3, 2021

Why not check prior in the constructor?

@gcp gcp changed the title Check whether prior values are valid. [MRG] Check whether prior values are valid. Apr 5, 2021
@gcp
Copy link
Contributor Author

gcp commented Apr 5, 2021

@kernc Sounds logical, fixed.

@glouppe glouppe merged commit 273db8f into scikit-optimize:master Apr 14, 2021
@glouppe
Copy link
Member

glouppe commented Apr 14, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skopt.Space prior does not check argument validity

3 participants