Skip to content

511 modulenotfounderror no module named mapieconformity scoresresidual conformity scores #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vincentblot28 merged 14 commits into from
Sep 12, 2024
Merged

511 modulenotfounderror no module named mapieconformity scoresresidual conformity scores #514

vincentblot28 merged 14 commits into from
Sep 12, 2024

Conversation

@vincentblot28
Copy link
Collaborator

@vincentblot28 vincentblot28 commented Sep 10, 2024

Fixes #511

@vincentblot28 vincentblot28 linked an issue Sep 10, 2024 that may be closed by this pull request
ModuleNotFoundError: No module named 'mapie.conformity_scores.residual_conformity_scores' #511
Closed
@Valentin-Laurent
Copy link
Collaborator

Valentin-Laurent commented Sep 10, 2024

Hello @vincentblot28,
Conformity scores are not the only imports breaking with MAPIE 0.9.0, I also listed the following:

from mapie.estimator.estimator import EnsembleRegressor
from mapie.conformity_scores.utils_classification_conformity_scores import get_true_label_position

Finally, theoretical_description_conformity_scores.rst now mentions outdated class names.

Let me know if you can take care of the above points. Thanks!

Valentin-Laurent
Valentin-Laurent reviewed Sep 11, 2024
View reviewed changes
thibaultcordier
thibaultcordier approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for also handling the other classes that were likely to have the same problem.

@vincentblot28 vincentblot28 merged commit c23039a into master Sep 12, 2024
@Valentin-Laurent Valentin-Laurent deleted the 511-modulenotfounderror-no-module-named-mapieconformity_scoresresidual_conformity_scores branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valentin-Laurent Valentin-Laurent Valentin-Laurent left review comments

@thibaultcordier thibaultcordier thibaultcordier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'mapie.conformity_scores.residual_conformity_scores'

4 participants

@vincentblot28 @Valentin-Laurent @thibaultcordier