ENH: externalize MapieClassifier methods into several non-conformity scores #476

thibaultcordier · 2024-07-01T14:52:32Z

Description

Outsource the MapieClassifier methods (LAC, APS, RAPS, TOPK) by extending the non-conformity score class to the classification task.

Fixes #467

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Test that existing code continues to work
Test that the proposed solution can enable new non-conformity scores

Checklist

I have read the contributing guidelines
I have updated the HISTORY.rst and AUTHORS.rst files
Linting passes successfully : make lint
Typing passes successfully : make type-check
Unit tests pass successfully : make tests
Coverage is 100% : make coverage
Documentation builds successfully : make doc

…ores + generic adaptation

…or classification score

… classification

vincentblot28 · 2024-07-04T09:02:57Z

What a tour de force @thibaultcordier !! Great improvement to the classification API !
General comment about the example: as in the future we prefer to use directly the conformity scores (and the argument "method" might be removed) I think examples should follow the new way of using MapieClassifier

mapie/classification.py

mapie/conformity_scores/sets/aps.py

mapie/conformity_scores/sets/naive.py

mapie/conformity_scores/sets/raps.py

mapie/regression/regression.py

mapie/classification.py

mapie/conformity_scores/sets/naive.py

mapie/conformity_scores/sets/aps.py

mapie/classification.py

mapie/conformity_scores/interface.py

mapie/conformity_scores/regression.py

mapie/conformity_scores/classification.py

mapie/conformity_scores/sets/naive.py

mapie/conformity_scores/sets/aps.py

mapie/conformity_scores/sets/lac.py

mapie/conformity_scores/sets/raps.py

mapie/regression/time_series_regression.py

UPD: factorize MapieClassifier methods into several non-conformity sc…

d3bcba5

…ores + generic adaptation

thibaultcordier added enhancement labels Jul 1, 2024

thibaultcordier requested review from LacombeLouis and vincentblot28 July 1, 2024 14:52

thibaultcordier self-assigned this Jul 1, 2024

thibaultcordier linked an issue Jul 1, 2024 that may be closed by this pull request

Extending the NCS class to the classification task #467

Closed

thibaultcordier changed the title ~~UPD: externalize MapieClassifier methods into several non-conformity scores~~ ENH: externalize MapieClassifier methods into several non-conformity scores Jul 1, 2024

Thibault Cordier added 10 commits July 1, 2024 16:58

FIX: path access in test doctring

0eb7203

FIX: adapt exemple code with new signatures

fc0f46a

UPD: check tests for additional parameters in residual normalized score

f064cc9

UPD: typing and doctring in score classes

a9c03fd

UPD: use y_enc as additional parameters to conserve label encoding

7f791dd

UPD: change greater equal to less equal

1b99529

UPD: docstring to explain parameters of get_sets

e588a3e

UPD: remove useless methods et attributes (estimation distribution) f…

8832a2e

…or classification score

UPD: decompose APS into Naive, APS and RAPS + new abtract methods for…

8fa2474

… classification

UPD: improve docstring of score classes

c79d6e5

thibaultcordier marked this pull request as ready for review July 3, 2024 16:20

UPD: refacto changes in history file

59586a9

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/classification.py Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/aps.py Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/aps.py Outdated Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/naive.py Outdated Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/naive.py Outdated Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/naive.py Outdated Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/naive.py Outdated Show resolved Hide resolved

vincentblot28 reviewed Jul 4, 2024

View reviewed changes

mapie/conformity_scores/sets/raps.py Outdated Show resolved Hide resolved

UPD: add missing attributes + keep quantiles_ attribute

7d053b7

Thibault Cordier added 3 commits July 15, 2024 10:32

UPD: short value check command

7b64f6f

FIX: unhashable list

262a96a

UPD: set_external_attributes common method

1e0b66c