Skip to content

Updating sphinx version #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thibaultcordier merged 7 commits into from
Jun 13, 2024
Merged

Updating sphinx version #466

thibaultcordier merged 7 commits into from
Jun 13, 2024

Conversation

@LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Jun 13, 2024 •
edited
Loading

Description

Update the version of sphinx to 5.3.0 to allow doc to create correctly.

Fixes issue #465.

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis linked an issue Jun 13, 2024 that may be closed by this pull request
Documentation build failure #465
Closed
@LacombeLouis LacombeLouis self-assigned this Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (5bd2456).
Report is 461 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master      #466    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        41     +2     
  Lines         4616      4954   +338     
  Branches       487       812   +325     
==========================================
+ Hits          4616      4954   +338

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thibaultcordier
thibaultcordier approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your correction!

@thibaultcordier thibaultcordier merged commit cbb3561 into master Jun 13, 2024
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Open
@Valentin-Laurent Valentin-Laurent deleted the 465-documentation-build-failure branch November 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibaultcordier thibaultcordier thibaultcordier approved these changes

Assignees

@LacombeLouis LacombeLouis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation build failure

3 participants

@LacombeLouis @codecov-commenter @thibaultcordier