FIX bug #452: Quantile Correction #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 27, 2024 12:07
LacombeLouis
requested changes
May 30, 2024
Collaborator
LacombeLouis
left a comment
LacombeLouis
left a comment
There was a problem hiding this comment.
Hey @thibaultcordier,
thank you for this PR. I think this should fix the issue that has been identified in the video.
I've added some comments and I think to conclude the PR it would be beneficial to add a new issue to be able to setup any quantile method.
Thank you
LacombeLouis
approved these changes
Jun 7, 2024
Collaborator
LacombeLouis
left a comment
LacombeLouis
left a comment
There was a problem hiding this comment.
When the final comments are done, then I think we can finish this issue and make a release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the corrected quantile ($|(n+1)(1−α)|/n$ ) to check the validity of the coverage for any number of calibration data.
Fixes #452
Type of change
How Has This Been Tested?
Checklist
make lintmake type-checkmake testsmake coveragemake doc