Building of Ensemble Classifier from MapieClassifier #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larger dataset (raps limitation)
LacombeLouis
requested changes
Jun 28, 2024
Collaborator
There was a problem hiding this comment.
Hey @thibaultcordier,
Great PR, thank you! Really clarifies the structure of MapieClassifier as it should have been.
Thank you!
LacombeLouis
requested changes
Jul 1, 2024
Collaborator
LacombeLouis
left a comment
LacombeLouis
left a comment
There was a problem hiding this comment.
Hey @thibaultcordier,
Just a last small change, be careful when changing tests, we don't want to reduce the generality of the tests performed!
LacombeLouis
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #430
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Adapt existing unit tests to the new class and check that everything still works.
Checklist
make lintmake type-checkmake testsmake coveragemake doc