415 documentation for winkler interval score #444
Conversation
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Wow, this detailed page explaining MAPIE metrics is awesome. Thank you so much for listing everything here.
I've commented on the style and a question about the equations being too similar.
README.rst
Outdated
| :height: 45px | ||
| :width: 45px |
There was a problem hiding this comment.
Incorrect image scale (distorted).
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
Co-authored-by: Thibault Cordier <[email protected]>
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Thank you for your changes. I just need to add a few harmonised changes. At the same time, I can't see your changes in the documentation (bug because there are a lot of builds / a lot of commits). I suggest you make a single commit for all the suggested changes with the "Add suggestion to batch" option in GitHub.
Co-authored-by: Thibault Cordier <[email protected]>
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Add line breaks, and it will be perfect.
Co-authored-by: Thibault Cordier <[email protected]>
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Simply add a line break to the format and you're done.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 39 41 +2
Lines 4616 4803 +187
Branches 487 363 -124
==========================================
+ Hits 4616 4803 +187 ☔ View full report in Codecov by Sentry. |
Valentin-Laurent
deleted the
415-documentation-for-winkler-interval-score
branch
3 participants
Description
Add description for all the metrics.
Fixes #415
Please remove options that are irrelevant.
Checklist
make lintmake type-checkmake testsmake coveragemake doc