425 readme page broken #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thibaultcordier
requested changes
May 13, 2024
Collaborator
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Thanks for the PR, which will tidy up the readme file. Just a few suggestions and questions before final approval.
thibaultcordier
approved these changes
May 13, 2024
Collaborator
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Thanks for your quick changes! Ready to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the read me logo failure.
Fixes #(issue)
Add the correct link to the logo
Please remove options that are irrelevant.
Checklist
make lintmake type-checkmake testsmake coveragemake doc