Skip to content

FIX: Put lower threshold for difference #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LacombeLouis merged 17 commits into from
May 13, 2024
Merged

FIX: Put lower threshold for difference #433

LacombeLouis merged 17 commits into from
May 13, 2024

Conversation

@LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Apr 18, 2024 •
edited
Loading

Description

Changes were made later in version 1.4.0: #27185 of the _sigmoid_calibration. (note slight changes in 1.3.0 #26913).

Note additional issues with environments:

  • CI is limited to version 1.2.2 of scikit-learn (due to numpy 1.25.2) --> why do we need to fix the numpy version?

Fixes #(issue)

  • Lower threshold for testing if different. This is just a short term fix.
  • Remove class test with printing

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis linked an issue Apr 18, 2024 that may be closed by this pull request
Issue with version 1.4.2 of scikit-learn #432
Closed
@LacombeLouis LacombeLouis self-assigned this Apr 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (0228014).
Report is 284 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master      #433    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        39            
  Lines         4616      4895   +279     
  Branches       487       801   +314     
==========================================
+ Hits          4616      4895   +279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LacombeLouis and others added 12 commits April 19, 2024 13:53
@LacombeLouis
Copy link
Collaborator Author

LacombeLouis commented May 6, 2024

This closes with #440.

@LacombeLouis LacombeLouis merged commit 2744d2f into master May 13, 2024
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Open
@Valentin-Laurent Valentin-Laurent deleted the 432-issue-with-mapie-dev-environment branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibaultcordier thibaultcordier Awaiting requested review from thibaultcordier

@vincentblot28 vincentblot28 Awaiting requested review from vincentblot28

Assignees

@LacombeLouis LacombeLouis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with version 1.4.2 of scikit-learn

3 participants

@LacombeLouis @codecov-commenter @BaptisteCalot