ENH: move get_true_label_position to utils in classification #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapie/tests/test_classification.py
Outdated
|
|
||
| mapie = MapieClassifier(random_state=random_state) | ||
| found_place = mapie._get_true_label_position(y_pred_proba, y_true) | ||
| found_place = get_true_label_position(y_pred_proba, y_true) |
Collaborator
There was a problem hiding this comment.
This test should be implemented directly in test_utils_classification_conformity_scores
| expected_position = np.array([[0], [0], [1], [1]]) | ||
|
|
||
| assert np.array_equal(position, expected_position) | ||
| assert position.shape == y.shape |
Collaborator
There was a problem hiding this comment.
Your tests must test only one thing at a time. For the test on the shape, you can take some random np arrays with larger sizes
This was referenced Apr 12, 2024
Collaborator
|
Hey @BaptisteCalot, |
thibaultcordier
approved these changes
May 14, 2024
Collaborator
thibaultcordier
left a comment
thibaultcordier
left a comment
There was a problem hiding this comment.
Thank you for your first PR, which is appropriate for the problem to be solved.
Valentin-Laurent
deleted the
426-move-some-methods-of-mapieclassifier-to-a-utils-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1- Move get_true_label_position function from classification.py to a new utils file
2- Add a test for this function
How Has This Been Tested?
1- Check if the return of my function is correct
2- Check if the shape of my function's return is correct