[MRG + 1] Removes estimator method check in cross_val_predict before fitting#9641
Merged
NelleV merged 2 commits intoscikit-learn:masterfrom Aug 30, 2017
Merged
Conversation
Member
|
Can you add your minimum example as a test please? |
Contributor
Author
|
Yeah sure. Just a regression test that makes sure |
Member
|
yes :) |
Member
|
thanks, lgtm :) |
amueller
changed the title
Contributor
Author
|
Awesome, thanks @amueller ! |
Member
|
Thanks @jrbourbeau |
Member
|
@jrbourbeau because you wrote "fixes issue #..." and not just "fixes #..." the issue didn't automatically close. Please take care in the future! Thanks for your contributions. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 30, 2017
…fitting (scikit-learn#9641) * Removes check in cross_val_predict that checks estimator method before fitting * Adds regression test for issue scikit-learn#9639
Contributor
Author
|
@jnothman will do. I didn't realize that using "fixes #..." automatically closes issues, that's a pretty handy feature! |
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…fitting (scikit-learn#9641) * Removes check in cross_val_predict that checks estimator method before fitting * Adds regression test for issue scikit-learn#9639
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…fitting (scikit-learn#9641) * Removes check in cross_val_predict that checks estimator method before fitting * Adds regression test for issue scikit-learn#9639
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes issue #9639
What does this implement/fix? Explain your changes.
This PR removes a check in
model_selection.cross_val_predictthat checks if an estimator has a method before the estimator is fit, causing aNotFittedErrorto be raised in some cases (e.g. when usingSGDClassifier).