Skip to content

Conversation

@amueller
Copy link
Member

@amueller amueller commented Aug 1, 2017

Minor fixup after #8875.
We definitely need to call show. The rest is more aesthetic.

before:
image
after:
figure_1

@amueller
Copy link
Member Author

amueller commented Aug 1, 2017

Actually I might prefer
image
image

image

or
image

or
image

@amueller
Copy link
Member Author

amueller commented Aug 1, 2017

Maybe 6 is best. the generic case is three points on the boundary, right?

@jnothman
Copy link
Member

jnothman commented Aug 1, 2017

6 or 7 looks good

@NelleV
Copy link
Member

NelleV commented Aug 4, 2017

I agree with 6 or 7 as well!

random_state=6 is the aesthetics consensus
@jnothman jnothman merged commit de26c30 into scikit-learn:master Aug 6, 2017
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 6, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
* change data, don't regularize, call plt.show
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants