Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

Fixes a bunch of not working links to examples.

@amueller
Copy link
Member

Looks good, I think. Maybe let's wait for sphinx to render


:class:`Imputer` can be used in a Pipeline as a way to build a composite
estimator that supports imputation. See :ref:`sphx_glr_auto_examples_missing_values.py`
estimator that supports imputation. See :ref:`sphx_glr_auto_examples_plot_missing_values.py`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a sentence, needs to end in a period.


Finally it is possible to discover the main topics of a corpus by
relaxing the hard assignment constraint of clustering, for instance by
using :ref:`NMF`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of this pr, but this also renders incorrectly: it prints the full name of the doc section. Could you make it simply print NMF?

@vene
Copy link
Member

vene commented Jun 10, 2017

All links that have been touched render correctly.

I requested two minor changes only :)

@lesteve
Copy link
Member

lesteve commented Jun 12, 2017

Added a missing dot, merging thanks a lot!

@lesteve lesteve merged commit 2537c31 into scikit-learn:master Jun 12, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants