[MRG+1] Run sphinxext doctests only on CircleCI #8228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Jan 24, 2017
Member
jnothman
left a comment
jnothman
left a comment
There was a problem hiding this comment.
I still think it's worth running test-sphinxext somewhere, but on Circle, perhaps not in the main tests.
lesteve
force-pushed
the
remove-test-sphinxext
branch
from
655a942 to
65052e1
Compare
Member
Author
Hmm I made the change without being really convinced. IMO we are very unlikely to find problems in sphinx extensions through doctests. |
lesteve
force-pushed
the
remove-test-sphinxext
branch
from
65052e1 to
a658648
Compare
lesteve
changed the title
lesteve
changed the title
lesteve
force-pushed
the
remove-test-sphinxext
branch
from
797e28b to
8328a7f
Compare
Some sphinx extensions import sphinx in their doctests.
lesteve
force-pushed
the
remove-test-sphinxext
branch
from
8328a7f to
e790fe4
Compare
Member
Author
|
This should be green now, I had to overcome some idiosyncrasies of CircleCI (mostly that each command is run in a separate shell, so you have to reactivate the conda env in each command). |
jnothman
changed the title
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Some sphinx extensions import sphinx in their doctests.
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
Some sphinx extensions import sphinx in their doctests.
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
Some sphinx extensions import sphinx in their doctests.
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
Some sphinx extensions import sphinx in their doctests.
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Some sphinx extensions import sphinx in their doctests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the documentation on CircleCI is a better test. Also doctests are generally not very extensive tests and sphinx extensions indoc/sphinxextare third party libraries and we should not be the ones testing it.sphinx extensions may have dependencies, e.g. sphinx.
Discussed in #8222 (comment). ping @jnothman.