Same pull request as before #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or liblinear predict
Member
|
Oops sorry, I have probably clicked on the "comment & close" button Thanks for fixing the code style, I appreciate this effort very much and I know that receiving feedback on code style rather than the actual work is always what's expected in the first place. I let Fabian do the merge as he knows better the LinearSVC API. |
Member
|
Good for me. I'll push it, thanks for the review Olivier |
HarshitZom
added a commit
to HarshitZom/scikit-learn
that referenced
this pull request
Nov 23, 2025
Ensure that transformers like SelectKBest and SelectPercentile retain the input dtypes when using pandas output, addressing scikit-learn#72. Adds a dtypes argument to _wrap_in_pandas_container to cast output columns to original dtypes, preserving categorical and custom types for downstream analysis.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pull request got closed before it was accepted ...
I fixed ALL the pep8 errors in the file so that I could see what was going wrong in my code section, and now everything is pep8-compliant !!!! Yay! (Ok, I know it's important.)
.