[MRG] FIX Use float64 instead of float.#5356
Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom Oct 8, 2015
Merged
Conversation
Member
|
LGTM. Let's wait for appveyor to complete. |
Member
|
Unfortunately it can still randomly fail even with this fix: |
085f2c9 to
86be478
Compare
Member
|
So this is not fixing the original issue but it's a good practice to fix the precision level we expect from the input data and not rely on possibly platform specific defaults. Merging. |
ogrisel
added a commit
that referenced
this pull request
Oct 8, 2015
[MRG] FIX Use float64 instead of float.
Contributor
|
If one would like to fix those over all sklearn, it's easy to find them. |
Member
Author
|
|
Contributor
|
They are many more than I thought :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix #4914 (#5235)
Note: This fix is useful but does not fix #4914
Thanks to @giorgiop!!