improvements to k-means (and one PCA thing) #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying all the k_init parameters as optional arguments - invite user to use a lambda or something
… allowing optional in-place operation
…airs_l2_distances_squared
Contributor
Author
|
@alex - I have made the formatting changes you suggested, and modified k-means to use the euclidean_distances function rather than the local function I had written for that. To keep the same level of speed though, I added a two new optional arguments to the euclidean_distances function. What do you think? |
Member
|
I did some more PEP8 cosmits and merged it to master. Thank you all :) |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 20, 2016
BUG: restore support for Python 3.4.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback from the pull request I sent this afternoon - I made those changes and more, hopefully you like this set better.