Skip to content

[MRG] Explain why we are somewhat selective, lower citiation rule of thumb#4131

Merged
jnothman merged 1 commit intoscikit-learn:masterfrom
amueller:faq_no_1000_citations
Jan 26, 2015
Merged

[MRG] Explain why we are somewhat selective, lower citiation rule of thumb#4131
jnothman merged 1 commit intoscikit-learn:masterfrom
amueller:faq_no_1000_citations

Conversation

@amueller
Copy link
Copy Markdown
Member

I lowered the 1000+ citations to 200+ citations (I think suggested by @mblondel), and tried to add an explanation and link to the discussion about why we are selective.

doc/faq.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: relies on

@GaelVaroquaux
Copy link
Copy Markdown
Member

+1 For merge.

@jnothman
Copy link
Copy Markdown
Member

LGTM, thanks @amueller. Merging.

jnothman added a commit that referenced this pull request Jan 26, 2015
[MRG] Explain why we are somewhat selective, lower citiation rule of thumb
@jnothman jnothman merged commit ca55e74 into scikit-learn:master Jan 26, 2015
@amueller
Copy link
Copy Markdown
Member Author

@GaelVaroquaux Feel free to add more to it and push to master, or ping me. I just didn't want to change the "inclusion criterion" without consent.

@amueller amueller deleted the faq_no_1000_citations branch January 26, 2015 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants