Skip to content

ENH Add from_cv_results to DetCurveDisplay#32235

Draft
lucyleeow wants to merge 6 commits intoscikit-learn:mainfrom
lucyleeow:cv_results_det
Draft

ENH Add from_cv_results to DetCurveDisplay#32235
lucyleeow wants to merge 6 commits intoscikit-learn:mainfrom
lucyleeow:cv_results_det

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

@lucyleeow lucyleeow commented Sep 21, 2025

Reference Issues/PRs

Follows on from #30508 and #30399

Should be merged AFTER #30508

What does this implement/fix? Explain your changes.

  • Adds from_cv_results to DetCurveDisplay
  • Adds tests
    • I've pulled out common tests and put them in test_common_curve_display

This is what the docstring example produces (simple default from_cv_results plot):

image

Any other comments?

cc @glemaitre @jeremiedbb

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 21, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4a7af88. Link to the linter CI: here

@lucyleeow
Copy link
Copy Markdown
Member Author

Amending this to draft as I foresee a lot of merge conflicts with #30508 and it may be easier to just open a new PR.

@lucyleeow lucyleeow marked this pull request as draft October 24, 2025 04:38
@adrinjalali adrinjalali added this to Labs Dec 11, 2025
@adrinjalali adrinjalali moved this to Todo in Labs Dec 11, 2025
@adrinjalali adrinjalali moved this from Todo to Todo - High Priority in Labs Jan 26, 2026
@auguste-probabl auguste-probabl moved this from Todo - High Priority to Todo in Labs Feb 9, 2026
@lucyleeow lucyleeow moved this from In Progress to Todo in Visualization and displays Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

7 participants