CI Use right environment in Pyodide wheel upload#31078
CI Use right environment in Pyodide wheel upload#31078lesteve merged 1 commit intoscikit-learn:mainfrom
Conversation
|
Thanks, @lesteve!
Keeping environments fine-grained is nice, but it also causes a maintenance burden. Leaving it up to y'all to decide. :) |
|
I think it's fine to reuse this env. |
|
Maybe @adrinjalali or @thomasjpfan for a second opinion on the security aspect of sharing the |
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
I'm okay with reusing this environment for WASM wheels.
|
OK thanks, let's merge this then! |
|
Manual workflow now running at: https://github.com/scikit-learn/scikit-learn/actions/runs/14088599788 🤞 |
|
Pyodide wheels are on anaconda.org 🎉 https://anaconda.org/scientific-python-nightly-wheels/scikit-learn/files. |
4 participants
Follow-up of #29791 after the upload fails #29791 (comment) because the token is empty.
Not sure if we should use the same environment or if we should have a separate environment for the main wheels upload and the Pyodide wheel upload. In particular the Pyodide wheel upload only needs
SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKENand notSCIKIT_LEARN_STAGING_UPLOAD_TOKEN. cc @ogrisel.