Skip to content

MNT Use find_program in meson.build for tempita step#31058

Merged
ogrisel merged 35 commits intoscikit-learn:mainfrom
lesteve:meson-tempita-find-program
Mar 24, 2025
Merged

MNT Use find_program in meson.build for tempita step#31058
ogrisel merged 35 commits intoscikit-learn:mainfrom
lesteve:meson-tempita-find-program

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Mar 24, 2025

Taken out of #29791.

Follow what Numpy and scipy are doing, see scipy/scipy#20121 for scipy.

and trigger [pyodide] wheel build
and trigger [pyodide] wheel builds
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d213a66. Link to the linter CI: here

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agriyakhetarpal
Copy link
Contributor

Thanks, @lesteve!

@ogrisel ogrisel merged commit ade815c into scikit-learn:main Mar 24, 2025
34 checks passed
@lesteve lesteve deleted the meson-tempita-find-program branch March 24, 2025 17:14
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants