TST use global_random_seed in sklearn/decomposition/tests/test_kernel_pca.py #30518
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test_kernel_pca.py
ArturoAmorQ
added
No Changelog Needed
Quick Review
Member
|
Please push an extra empty commit to this PR to trigger the updated tests with all admissible random seeds on all CI runners as documented in #28959. |
Contributor
Author
Will do! |
test_kernel_pca test_kernel_pca_consistent_transform test_kernel_pca_deterministic_output test_kernel_pca_sparse test_kernel_pca_linear_kernel test_kernel_pca_n_components test_kernel_pca_precomputed test_kernel_pca_inverse_correct_gamma
yuanx749
reviewed
Jan 8, 2025
OmarManzoor
reviewed
Jan 14, 2025
OmarManzoor
approved these changes
Jan 14, 2025
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @pedro9olivares
Member
|
Congrats on your first merge in scikit-learn, @pedro9olivares! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm opening this PR in regards to this issue.
Modified the following functions:
Added an additional argument "global_random_seed" for the RandomState which was previously hardcoded.