Fix performance regression in ColumnTransformer#29330
Merged
ogrisel merged 2 commits intoscikit-learn:mainfrom Jun 28, 2024
Merged
Fix performance regression in ColumnTransformer#29330ogrisel merged 2 commits intoscikit-learn:mainfrom
ogrisel merged 2 commits intoscikit-learn:mainfrom
Conversation
betatim
approved these changes
Jun 24, 2024
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
I don't think we can add a regression test for this. So it is Ok to not have one.
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
added a commit
that referenced
this pull request
Jul 2, 2024
snath-xoc
pushed a commit
to snath-xoc/scikit-learn
that referenced
this pull request
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29229
#28822 was a quick fix for #28781 before releasing 1.5.0. It turns out that it caused a performance regression when the input can't be memory mapped, for instance columns where elements are arrays of variable length. In that case the whole
Xis copied in each subprocess.Since #29018 has now been merged, we can revert #28822 because it also fixes #28781 without causing the performance regression (note that I kept the non regression test). The following results of the snippet from #29229 with this PR are close to the 1.4.2 ones: