Skip to content

FIX missing force_writeable in KernelCenterer.transform#29328

Merged
lesteve merged 1 commit intoscikit-learn:mainfrom
ogrisel:fix-force_writeable-in-KernelPCA.transform
Jun 21, 2024
Merged

FIX missing force_writeable in KernelCenterer.transform#29328
lesteve merged 1 commit intoscikit-learn:mainfrom
ogrisel:fix-force_writeable-in-KernelPCA.transform

Conversation

@ogrisel
Copy link
Member

@ogrisel ogrisel commented Jun 21, 2024

Fix the CI failure on main described here: #29325 (comment) caused by the recently concurrently merged fixes in #29018 and #29100.

/cc @jeremiedbb @lesteve.

Fixes #29326
Fixes #29325
Fixes #29324
Fixes #29323

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Jun 21, 2024
@github-actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: cd677b3. Link to the linter CI: here

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lesteve lesteve enabled auto-merge (squash) June 21, 2024 08:12
@lesteve
Copy link
Member

lesteve commented Jun 21, 2024

I enabled auto-merge, to avoid having red CIs in PRs

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just to see if the new common test is useful, all planned ! 😄

@lesteve lesteve merged commit a490ab1 into scikit-learn:main Jun 21, 2024
@ogrisel ogrisel deleted the fix-force_writeable-in-KernelPCA.transform branch June 21, 2024 09:11
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
11 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment