CI Update upload-artifact and download-artifact to v4#29211
Merged
thomasjpfan merged 2 commits intoscikit-learn:mainfrom Jun 7, 2024
Merged
CI Update upload-artifact and download-artifact to v4#29211thomasjpfan merged 2 commits intoscikit-learn:mainfrom
thomasjpfan merged 2 commits intoscikit-learn:mainfrom
Conversation
thomasjpfan
approved these changes
Jun 7, 2024
This was referenced Jun 19, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Jul 2, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed https://learn.scientific-python.org/development/guides/gha-wheels for wheel workflow.
This will be tested in this PR with the
[cd build gh]comment. Actually the "Upload to Anaconda" is skipped but I triggered in on my fork and everything looks fine, see https://github.com/lesteve/scikit-learn/actions/runs/9414784335.The lint workflow is probably fine because there is a single artifact.
For more details about the v3 -> v4 upgrade: https://github.blog/2024-02-12-get-started-with-v4-of-github-actions-artifacts/#compatibility
Context: Dependabot PR #29203