DEPR deprecate copy parameter in Birch#29124
Merged
jeremiedbb merged 10 commits intoscikit-learn:mainfrom Jun 21, 2024
Merged
Conversation
OmarManzoor
reviewed
May 28, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
Thanks for the PR @Charlie-XIAO. A few minor comments otherwise looks good.
jeremiedbb
reviewed
Jun 4, 2024
jeremiedbb
reviewed
Jun 21, 2024
jeremiedbb
approved these changes
Jun 21, 2024
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Charlie-XIAO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29092.
This PR deprecates the
copyparameter inBirchsince it has no effect and a copy will always be made regardless of this parameter. See the linked issue for more details.