Skip to content

DOC Add 1.4.2 to News #28797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lesteve merged 1 commit into from
Apr 10, 2024
Merged

DOC Add 1.4.2 to News #28797

lesteve merged 1 commit into from
Apr 10, 2024

Conversation

@jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Apr 9, 2024

I only did it in the 1.4.2 release branch. Usually we do it in the main branch and backport in the release branch but I forgot this one.

This PR also switches 1.4.1 to 1.4.1.post1 as was done in 1.4.X for the 1.4.1.post1 release but was apparently also not done in main at the time as well.

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Apr 9, 2024
@github-actions
Copy link

github-actions bot commented Apr 9, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3f455a9. Link to the linter CI: here

@lesteve
Copy link
Member

lesteve commented Apr 10, 2024 •
edited
Loading

Not related to this PR at all, but the no-OpenMP build-time failure looks like a variant of the one that was fixed in #28789.

[61/249] Compiling Cython source sklearn/linear_model/_sgd_fast.pyx
FAILED: sklearn/linear_model/_sgd_fast.cpython-312-darwin.so.p/sklearn/linear_model/_sgd_fast.pyx.c
cython -M --fast-fail -3 '-X language_level=3' '-X boundscheck=False' '-X wraparound=False' '-X initializedcheck=False' '-X nonecheck=False' '-X cdivision=True' '-X profile=False' --include-dir /Users/runner/work/1/s/build/cp312 sklearn/linear_model/_sgd_fast.pyx -o sklearn/linear_model/_sgd_fast.cpython-312-darwin.so.p/sklearn/linear_model/_sgd_fast.pyx.c


from cython cimport floating
from libc.math cimport exp, fabs, isfinite, log, pow, INFINITY

from ..utils._typedefs cimport uint32_t
^
------------------------------------------------------------

sklearn/linear_model/_sgd_fast.pyx:9:0: relative cimport from non-package directory is not allowed

@lesteve lesteve enabled auto-merge (squash) April 10, 2024 05:38
@lesteve
Copy link
Member

lesteve commented Apr 10, 2024

I have enabled auto-merge

@lesteve lesteve merged commit 796a5cb into scikit-learn:main Apr 10, 2024
This was referenced Apr 11, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesteve lesteve lesteve approved these changes

Assignees

No one assigned

Labels

Documentation Quick Review For PRs that are quick to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremiedbb @lesteve