BLD Fix build dependency in meson build #28789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was seen from time to time in the no-OpenMP build e.g. in #28757 (comment), see build log and more recently in
mainCI build log. The error looks like this:The root cause is likely that the dependency are not correctly defined in the
meson.buildfiles. This is not detected byninja -C build/cp312 -t missingdepsmaybe because this is a ninja template.pxd.tprather than a.pxdfile?Here are the two files that need it
_dist_metrics.pxd:I have not been able to reproduce locally so I don't know for sure that this fixes the problem, but looking at the generated
ninja.buildfile, it does seem like_dist_metrics_pxdwill be a dependency of the two files that need it.