CLN Support _MultimetricScorer directly for internal methods #28359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
changed the title
adrinjalali
approved these changes
Feb 6, 2024
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
This works. I wanted to do a similar thing while working on slep6, but it seemed dirty. I like this reverse if on _MultimetricScorer now.
Member
|
@OmarManzoor maybe you could have a look? Should be a quick review. |
OmarManzoor
approved these changes
Feb 6, 2024
Contributor
OmarManzoor
left a comment
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @thomasjpfan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #27001
What does this implement/fix? Explain your changes.
This PR simplifies the handling of multi-metric
scoring, by always convertingscoringdicts to a_MultimetricScorerat the start of a public function call.