Conversation
|
So the hdbscan one seems recent since it was not in my previous commit, this seems like a numpy change that somehow changes the HDBSCan labels, to be investigated: numpy dev numpy release |
|
So It looks like |
|
A snippet that shows the numpy dev change: import hashlib
import numpy as np
hashlib.sha256(np.argsort(np.random.default_rng(0).integers(100, size=10_000)).tobytes()).hexdigest()numpy 1.26.3 numpy dev
|
This reverts commit 37fb33e.
adrinjalali
left a comment
There was a problem hiding this comment.
CI seems happy. Thanks @lesteve
| """ | ||
| centers = [(0.0, 0.0), (3.0, 3.0)] | ||
| H, _ = make_blobs(n_samples=1000, random_state=0, centers=centers, cluster_std=0.5) | ||
| H, _ = make_blobs(n_samples=2000, random_state=0, centers=centers, cluster_std=0.5) |
There was a problem hiding this comment.
oh wow, I thought this is more like, increasing from 10 samples to 100. But with 1000 samples and two dimensions, this should be quite stable, having it so unstable is concerning. I understand why this is though, but still.
cc @Micky774
There was a problem hiding this comment.
Right, this seems to be the most brittle piece. I'm not sure why, but it should really only be used for illustrative purposes anyways (with exceptions if you really know the shape of your data). Even then it still is too fickle for full comfort. I'd love to investigate in detail if I get the time for it 😭
This fixes a DeprecationWarning in Numpy 2.0
a->S. There may be other errors since scipy-dev has not been run without errors for a while ...Close #28194.