TST Fix locally_linear_embedding test with scipy-dev#27628
Merged
glemaitre merged 2 commits intoscikit-learn:mainfrom Oct 20, 2023
Merged
TST Fix locally_linear_embedding test with scipy-dev#27628glemaitre merged 2 commits intoscikit-learn:mainfrom
glemaitre merged 2 commits intoscikit-learn:mainfrom
Conversation
ogrisel
approved these changes
Oct 20, 2023
Member
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM if CI is effectively green.
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #27578
The test_singular_matrix one is probably due to scipy using upstream SuperLU code scipy/scipy#19284. This seems to change the behaviour slightly. In particular the smallest eigenvalue is not exactly 0 but of the order of 1e-16 and the error is not raised.