MNT mark non-standard inverse_transform X args as non-metadata (SLEP6) #26503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2023
Member
|
I wouldn't mind having a consistent API for inverse_transform, deprecating |
Member
Author
|
@jeremiedbb done |
jeremiedbb
reviewed
Jun 8, 2023
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
The 2 deprecations will need |API| entries in the changelog. Otherwise I made a few suggestions but looks good overall
Comment on lines
+1274
to
+1275
| if Xt is None and W is None: | ||
| raise TypeError("Missing required positional argument: Xt") |
Member
There was a problem hiding this comment.
feels a bit weird but I think it's fine since it's only during the deprecation cycle.
Member
Author
There was a problem hiding this comment.
yeah, I'm doing a TypeError here since python would do the same if user doesn't pass a positional arg.
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
scikit-learn#26503) Co-authored-by: jeremiedbb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_{method}_requestis generated for methods whenever they have arguments which are notX,y, orY. But forinverse_transformwe have a few places where we call the argument something else. This PR sets them explicitly asUNUSEDso that they're ignored by the metadata method generation mechanism andset_inverse_transform_requestmethod is not generated for them.I don't have a strong preference on adding
Xtand maybeyt/Ytto the hard coded list of ignored argument names.