STY Do not make whole space white in html repr #26485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
In principle fine with me. A bit hard to know what this could be breaking, but we can wait for bug reports if no one has an idea what else to test? |
adrinjalali
approved these changes
Jun 1, 2023
Member
adrinjalali
left a comment
adrinjalali
left a comment
There was a problem hiding this comment.
I think this is a good improvement. We shouldn't care much about people relying on the rendered version I think.
betatim
approved these changes
Jun 1, 2023
manudarmi
pushed a commit
to primait/scikit-learn
that referenced
this pull request
Jun 12, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #26364
What does this implement/fix? Explain your changes.
Before this PR, with VScode notebooks the HTML repr will make the whole cell white:
With this PR only the HTML repr is white:
Any other comments?
I'm still thinking about how to enable dark mode based on OS preferences. According to jupyterlab/jupyterlab#8777, Jupyter does not currently support the
prefers-color-schemeCSS media query.