Skip to content

Conversation

@jeremiedbb
Copy link
Member

The default value changes in 1.3 and whiten=True is no longer valid.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Jun 1, 2023
@jeremiedbb jeremiedbb added this to the 1.3 milestone Jun 1, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 2998f30 into scikit-learn:main Jun 2, 2023
manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants