Skip to content

Conversation

@joshuahedlund
Copy link
Contributor

Reference Issues/PRs

Fixes #26419

What does this implement/fix? Explain your changes.

  • Removes non-functional twitter.yml workflow
  • Removes references to the sklearn_commits twitter account that the workflow updated

Any other comments?

  • Technically this is not a "fix", but there was no objection to removing
  • I'm not sure if there are more technical things to update, whether in repo or out of it (especially secret values)
  • I'm not sure if there are communications to update (i.e. explain somewhere why the account is now abandoned, or delete it but explain that it used to exist, simply ignore it, etc)

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @joshuahedlund

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @joshuahedlund !

@thomasjpfan thomasjpfan merged commit e14046a into scikit-learn:main May 31, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The twitter workflow stopped working a few days ago

4 participants