Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

In Python 3, io.open() is an alias for the builtin open() function:
https://docs.python.org/3/library/io.html#io.open

Any other comments?

@thomasjpfan thomasjpfan changed the title [MRG] io.open() → open() CLN io.open() → open() May 28, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @DimitriPapadopoulos ! I am okay with this adjustment. LGTM!

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremiedbb jeremiedbb merged commit 1084860 into scikit-learn:main May 30, 2023
@DimitriPapadopoulos DimitriPapadopoulos deleted the io.open branch May 30, 2023 14:37
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants