ENH fix x- and y-axis limits and ratio in ROC and PR displays #26366
Conversation
|
Is this what we want? I think we want to set aspect to 1, especially for PR curves (see https://gist.github.com/Charlie-XIAO/ecd5173fe0daa9c49f442153ef19e7d1). With your ratio I'm getting PR curve plots like this: 
|
glemaitre
changed the title
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I run the example that would be modified and it looks good locally.
We can check if this is also the case with the CIs.
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
I checked the rendering on the generated documentation and this is fine.
Ready for merging.
@ArturoAmorQ do you want to make a pass such that we merge this one?
I have my eyes on it! 👀 |
ArturoAmorQ
left a comment
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Just a nitpick, after which it LGTM :)
Co-authored-by: Arturo Amor <[email protected]>
|
Merging thanks all. |
…-learn#26366) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Arturo Amor <[email protected]>
…-learn#26366) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Arturo Amor <[email protected]>
…-learn#26366) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Arturo Amor <[email protected]>
4 participants
related to #25929
We set the ratio to
1/ ax.get_data_ratio()to get square plotIt is related to point 3 as discussed in the issue #25929