MAINT Fix usage of property in Cython extension classes
#26297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Li <[email protected]>
thomasjpfan
changed the title
property in Cython extension classesproperty in Cython extension classes
thomasjpfan
approved these changes
Apr 29, 2023
Member
thomasjpfan
left a comment
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM
thomasjpfan
added
the
Waiting for Second Reviewer
adrinjalali
approved these changes
May 4, 2023
Member
|
There are merge conflicts, happy to merge once they're resolved. |
Member
Author
Done |
Member
|
Could you please maybe submit an empty commit to let the CI restart? git commit --allow-empty -m "trigger ci"should do it. |
Member
Author
Done. I don't need to update wrt main right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes: #26295
What does this implement/fix? Explain your changes.
Converts
propertydefinitions to the Python syntax, which removes the deprecation warning.Any other comments?
n/a