MAINT parameter validation for covariance.graphical_lasso #25911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@genvalen there is already a PR that is open: #25053 It was blocked because we first need to refactor the code such that the function @genvalen One potential thing would be to open a PR to refactor the code if you want. For instance, we did a similar change for the same reason in #25392 |
Contributor
Author
|
@glemaitre no problem, and yes, I can work on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Toward #24862
What does this implement/fix? Explain your changes.
Summary of changes:
covariance.graphical_lasso.Any other comments?