TST random seed global /svm/tests/test_svm.py #25891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veghit
changed the title
jeremiedbb
reviewed
Mar 21, 2023
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
Thanks for the PR @Veghit. There are many tests in this file that could use the global_random_seed since they currently use a fixed random_state
sklearn/svm/tests/test_svm.py
Outdated
Comment on lines
1076
to
1077
| X = np.random.RandomState(global_random_seed).randn(10, 3) | ||
| y = np.random.RandomState(global_random_seed + 1).randn(10) |
Member
There was a problem hiding this comment.
Suggested change
| X = np.random.RandomState(global_random_seed).randn(10, 3) | |
| y = np.random.RandomState(global_random_seed + 1).randn(10) | |
| rng = np.random.RandomState(global_random_seed) | |
| X = rng.randn(10, 3) | |
| y = rng.randn(10) |
…wer thresholds and other fixes.
…wer thresholds and other fixes.
… TST_random_seed_global_svm # Conflicts: # sklearn/svm/tests/test_svm.py
…cikit-learn#25811) Co-authored-by: Jérémie du Boisberranger <[email protected]>
added 11 commits
April 15, 2023 23:06
…wer thresholds and other fixes.
… TST_random_seed_global_svm # Conflicts: # sklearn/svm/tests/test_svm.py
Contributor
Author
|
@jeremiedbb fixed the rest of the tests |
test_libsvm_iris test_precomputed test_linearsvr_fit_sampleweight test_oneclass_decision_function test_probability test_decision_function test_decision_function_shape test_svr_predict test_weight test_auto_weight test_bad_input test_svc_nonfinite_params test_unicode_kernel test_linearsvc_parameters test_linearsvc test_linearsvc_crammer_singer test_linearsvc_fit_sampleweight test_crammer_singer_binary test_linearsvc_iris test_liblinear_set_coef test_immutable_coef_property test_svc_clone_with_callable_kernel test_libsvm_convergence_warnings test_consistent_proba test_linear_svm_convergence_warnings test_svr_coef_sign test_hasattr_predict_proba test_decision_function_shape_two_class test_svc_invalid_break_ties_param test_svc_ovr_tie_breaking test_linearsvm_liblinear_sample_weight test_n_iter_libsvm test_svm_with_infinite_C
test_libsvm_iris
test_precomputed
test_linearsvr_fit_sampleweight
test_oneclass_decision_function
test_probability
test_decision_function
test_decision_function_shape
test_svr_predict
test_weight
test_auto_weight
test_bad_input
test_svc_nonfinite_params
test_unicode_kernel
test_linearsvc_parameters
test_linearsvc
test_linearsvc_crammer_singer
test_linearsvc_fit_sampleweight
test_crammer_singer_binary
test_linearsvc_iris
test_liblinear_set_coef
test_immutable_coef_property
test_svc_clone_with_callable_kernel
test_libsvm_convergence_warnings
test_consistent_proba
test_linear_svm_convergence_warnings
test_svr_coef_sign
test_hasattr_predict_proba
test_decision_function_shape_two_class
test_svc_invalid_break_ties_param
test_svc_ovr_tie_breaking
test_linearsvm_liblinear_sample_weight
test_n_iter_libsvm
test_svm_with_infinite_C
test_libsvm_iris
test_precomputed
test_linearsvr_fit_sampleweight
test_oneclass_decision_function
test_probability
test_decision_function
test_decision_function_shape
test_svr_predict
test_weight
test_auto_weight
test_bad_input
test_svc_nonfinite_params
test_unicode_kernel
test_linearsvc_parameters
test_linearsvc
test_linearsvc_crammer_singer
test_linearsvc_fit_sampleweight
test_crammer_singer_binary
test_linearsvc_iris
test_liblinear_set_coef
test_immutable_coef_property
test_svc_clone_with_callable_kernel
test_libsvm_convergence_warnings
test_consistent_proba
test_linear_svm_convergence_warnings
test_svr_coef_sign
test_hasattr_predict_proba
test_decision_function_shape_two_class
test_svc_invalid_break_ties_param
test_svc_ovr_tie_breaking
test_linearsvm_liblinear_sample_weight
test_n_iter_libsvm
test_svm_with_infinite_C
test_libsvm_iris
test_precomputed
test_linearsvr_fit_sampleweight
test_probability
test_decision_function
test_decision_function_shape
test_svr_predict
test_bad_input
test_svc_nonfinite_params
test_unicode_kernel
test_linearsvc_parameters
test_linearsvc
test_linearsvc_crammer_singer
test_linearsvc_fit_sampleweight
test_crammer_singer_binary
test_linearsvc_iris
test_liblinear_set_coef
test_immutable_coef_property
test_svc_clone_with_callable_kernel
test_libsvm_convergence_warnings
test_consistent_proba
test_linear_svm_convergence_warnings
test_svr_coef_sign
test_hasattr_predict_proba
test_decision_function_shape_two_class
test_svc_invalid_break_ties_param
test_svc_ovr_tie_breaking
test_linearsvm_liblinear_sample_weight
test_n_iter_libsvm
test_svm_with_infinite_C
test_libsvm_iris
test_precomputed
test_linearsvr_fit_sampleweight
test_probability
test_decision_function
test_decision_function_shape
test_svr_predict
test_bad_input
test_svc_nonfinite_params
test_unicode_kernel
test_linearsvc_parameters
test_linearsvc
test_linearsvc_crammer_singer
test_linearsvc_fit_sampleweight
test_crammer_singer_binary
test_linearsvc_iris
test_liblinear_set_coef
test_immutable_coef_property
test_svc_clone_with_callable_kernel
test_libsvm_convergence_warnings
test_consistent_proba
test_linear_svm_convergence_warnings
test_svr_coef_sign
test_hasattr_predict_proba
test_decision_function_shape_two_class
test_svc_invalid_break_ties_param
test_svc_ovr_tie_breaking
test_linearsvm_liblinear_sample_weight
test_n_iter_libsvm
test_svm_with_infinite_C
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22827
What does this implement/fix? Explain your changes.
using random global seed for sklearn/svm/tests/test_svm.py to enable better testing.
Any other comments?
tests pass without logic changes. Decided to use global seed also for the test_svc_nonfinite_params test as it does not take much time and has some potential issues even though it is a simple test.