Skip to content

Conversation

@Micky774
Copy link
Contributor

@Micky774 Micky774 commented Mar 6, 2023

Reference Issues/PRs

Towards #24686

What does this implement/fix? Explain your changes.

  1. Renames variables
  2. Changes typing to follow scikit-learn standard
  3. Utilizes new Cython syntax and standards

Any other comments?

Note that this PR is derived from the changes made in #25658 but separated to limit scope.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given that this is all stylistic changes, I'll merge so we can move forward.

@thomasjpfan thomasjpfan merged commit 6d53e5c into scikit-learn:hdbscan Mar 7, 2023
@Micky774 Micky774 deleted the hdbscan_tree_style branch March 11, 2023 22:00
Micky774 added a commit to Micky774/scikit-learn that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants